Swift 3 API parity: Change type of HTTPURLResponse.allHeaderFields #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test linux |
| @@ -233,7 +233,8 @@ open class HTTPURLResponse : URLResponse { | |||
| /// This property is intended to produce readable output. | |||
| override open var description: String { | |||
| var result = "<\(type(of: self)) \(Unmanaged.passUnretained(self).toOpaque())> { URL: \(url!.absoluteString) }{ status: \(statusCode), headers {\n" | |||
| for(key, value) in allHeaderFields { | |||
| for(aKey, aValue) in allHeaderFields { | |||
| let (key,value) = (aKey as! String, aValue as! String) //allHeaderFields is either assigned a [String:String] or [:] | |||
There was a problem hiding this comment.
If we allow the header fields to be anything besides a string as part of the API, then shouldn't we use as? here? Otherwise we'll just assert in some cases.
There was a problem hiding this comment.
Yes, though allHeaderFields is always derived from a [String:String] we can have subclasses storing other types in it. I've updated the PR. Thanks.
pushkarnk
force-pushed
the
httpurlresponse
branch
from
5b25927 to
8c4087c
Compare
|
@swift-ci please test linux |
pushkarnk
force-pushed
the
httpurlresponse
branch
from
8c4087c to
9cff17e
Compare
pushkarnk
force-pushed
the
httpurlresponse
branch
from
9cff17e to
93c455f
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change type of HTTPURLResponse.allHeaderFields to [AnyHashable : Any] to match Darwin.